Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20733 )
Change subject: IMPALA-11805: Use llvm ObjectCache for codegen caching ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20733/2/be/src/codegen/llvm-codegen-cache-test.cc File be/src/codegen/llvm-codegen-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/20733/2/be/src/codegen/llvm-codegen-cache-test.cc@298 PS2, Line 298: // 172B for optimal mode, or 180B on ARM systems > Oh, I meant the largest difference I saw between normal and optimal mode is Did a test in both arm and x86. In our testcase of mem_charge_1, the mem charge in arm is always 8B larger than x86 in normal and optimal mode. For mem_charge_1, arm 188B/180B, x86 180B/172B. The current size setting should be good for testing, and I can pass the test in arm. http://gerrit.cloudera.org:8080/#/c/20733/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20733/2/be/src/codegen/llvm-codegen.cc@1385 PS2, Line 1385: > So bytes_allocated is still needed, which means we still want https://gerri >From the source code and gdb debugging that I can see, the bytes_allocated >will be used when loading from the pre-compiled object. >https://llvm.org/doxygen/MCJIT_8cpp_source.html#l00224. While the manage usage >of pre-compiled object is currently managed by the codegen cache if codegen >cache is enabled, the bytes_allocated is managed by the runtime execution >engine, I think bytes_allocated is still useful for runtime use no matter >codegen cache is on or off. -- To view, visit http://gerrit.cloudera.org:8080/20733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3c1b46bb9018ed0320817141785a3bdc41fa677 Gerrit-Change-Number: 20733 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 30 Nov 2023 10:00:35 +0000 Gerrit-HasComments: Yes
