Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 )
Change subject: IMPALA-3268: Add support for SHOW VIEWS statement ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/20669/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20669/9//COMMIT_MSG@16 PS9, Line 16: Table is not fully loaded until it is referenced in a query. I think if pull_table_types_and_comments is set to false, SHOW VIEWS can still work. But users have to make sure the views are loaded so they can be correctly shown in SHOW VIEWS statements. A view will be loaded when it's referenced in a query, e.g. a DESCRIBE statement. If load_catalog_in_background is set to true, SHOW VIEWS can still miss some views if they are unloaded yet. Note that background loading is done by a thread pool asynchronously. We have similar issues for checking the ownership on unloaded tables (described as an example in IMPALA-8937). http://gerrit.cloudera.org:8080/#/c/20669/9/tests/custom_cluster/test_show_views_statements.py File tests/custom_cluster/test_show_views_statements.py: http://gerrit.cloudera.org:8080/#/c/20669/9/tests/custom_cluster/test_show_views_statements.py@27 PS9, Line 27: LOAD_CATALOG_FLAG = "--load_catalog_in_background=true" I don't think we should test on this flag. The metadata is loaded in background so it's undetermined whether the views are loaded when the tests run. -- To view, visit http://gerrit.cloudera.org:8080/20669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I321fc5350392a815949a4e7d2a64d60466689788 Gerrit-Change-Number: 20669 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2023 12:03:25 +0000 Gerrit-HasComments: Yes
