Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 )
Change subject: IMPALA-3268: Add support for SHOW VIEWS statement ...................................................................... Patch Set 10: (2 comments) Thanks for the suggestions Quanlong! I slightly revised the commit message and removed the (flaky) tests against the flag of '--load_catalog_in_background=true'. Let me know if there are other suggestions. Thanks very much! http://gerrit.cloudera.org:8080/#/c/20669/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20669/9//COMMIT_MSG@16 PS9, Line 16: Impala the names of the Table's whose getTableType() evaluate to > I think if pull_table_types_and_comments is set to false, SHOW VIEWS can st Thanks for the detailed explanation Quanlong! I will revise the commit message accordingly in the next patch. http://gerrit.cloudera.org:8080/#/c/20669/9/tests/custom_cluster/test_show_views_statements.py File tests/custom_cluster/test_show_views_statements.py: http://gerrit.cloudera.org:8080/#/c/20669/9/tests/custom_cluster/test_show_views_statements.py@27 PS9, Line 27: > I don't think we should test on this flag. The metadata is loaded in backgr Thanks Quanlong! I will remove the tests against this flag in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/20669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I321fc5350392a815949a4e7d2a64d60466689788 Gerrit-Change-Number: 20669 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2023 19:48:15 +0000 Gerrit-HasComments: Yes
