Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20673 )
Change subject: IMPALA-12486: Add catalog metrics for metadata loading ...................................................................... Patch Set 6: (5 comments) > Patch Set 5: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9970/ The test failure seem to be a known issue of IMPALA-12266. https://jenkins.impala.io/job/ubuntu-20.04-dockerised-tests/871/ http://gerrit.cloudera.org:8080/#/c/20673/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20673/5//COMMIT_MSG@25 PS5, Line 25: asynchronousl > nit: asynchronous, same for L29 Done http://gerrit.cloudera.org:8080/#/c/20673/5//COMMIT_MSG@39 PS5, Line 39: is > nit: is Done http://gerrit.cloudera.org:8080/#/c/20673/5/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/20673/5/common/thrift/metrics.json@333 PS5, Line 333: . > nit: description sentences are usually terminated by a dot. Same goes for L Done http://gerrit.cloudera.org:8080/#/c/20673/5/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java: http://gerrit.cloudera.org:8080/#/c/20673/5/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@177 PS5, Line 177: Preconditions.checkNotNull(msTbl); > It should come after the precondition check Ah, right! http://gerrit.cloudera.org:8080/#/c/20673/5/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/20673/5/tests/webserver/test_web_pages.py@903 PS5, Line 903: json" > CATALOG_TEST_PORT could be used here Done -- To view, visit http://gerrit.cloudera.org:8080/20673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icef7b123bdcb0f5b8572635eeaacd8294990f9ba Gerrit-Change-Number: 20673 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2023 23:34:28 +0000 Gerrit-HasComments: Yes
