Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4371/3/be/src/exec/hdfs-parquet-scanner.h File be/src/exec/hdfs-parquet-scanner.h: PS3, Line 430: avg_timer_ > let's update the variable names too. e.g. something like process_footer_tim Done http://gerrit.cloudera.org:8080/#/c/4371/3/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: PS3, Line 240: Overwrite > "SetStats()" to be more consistent with some of the other fns, e.g. SetSamp Done http://gerrit.cloudera.org:8080/#/c/4371/3/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: PS3, Line 668: - > I don't see this dash in the example above? Is it intentional? I see the ev The dash comes before this, I added that now. I've made the changes according to how you suggested. It makes more sense that way. -- To view, visit http://gerrit.cloudera.org:8080/4371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
