Henry Robinson has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads ......................................................................
Patch Set 6: > Do we have any counters where we track running sum and number of samples and > compute the average by hand (or by the user) Good idea to check - but we should bear in mind that average is usually very uninformative for latency distributions. Where we try to measure average we usually want to measure percentiles (and we have a histogram class for that purpose). Sailesh - can you at least leave a TODO to consider replacing average measurements with histograms? Might be possible in this patch; I don't know how hard ToThrift() would be. -- To view, visit http://gerrit.cloudera.org:8080/4371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
