Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called ......................................................................
Patch Set 1: (1 comment) Agree that this maybe isn't a fix so much as an interface improvement, but I think it helps RowBatch be self-contained if I can AcquireState() from a batch using only that batch's interface. http://gerrit.cloudera.org:8080/#/c/4428/1/be/src/runtime/row-batch-test.cc File be/src/runtime/row-batch-test.cc: Line 60: ASSERT_DEBUG_DEATH(bad_dest.AcquireState(&src), ""); Will change to IMPALA_ASSERT_DEBUG_DEATH when related patch lands. -- To view, visit http://gerrit.cloudera.org:8080/4428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ceca53c406b05cd04b7d95a4f9f2eec7bc127f5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: Yes
