Tim Armstrong has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4428/1/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: Line 319: capacity_ = tuple_ptrs_size_ / (num_tuples_per_row_ * sizeof(Tuple*)); > What about just setting capacity_ = initial_capacity_ here? I don't feel strongly either way, but when this added I switched from the initial_capacity_ approach to the current approach to avoid redundant state: https://gerrit.cloudera.org/#/c/1399/8/be/src/runtime/row-batch.h@301 -- To view, visit http://gerrit.cloudera.org:8080/4428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ceca53c406b05cd04b7d95a4f9f2eec7bc127f5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
