Alex Behm has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. ......................................................................
Patch Set 16: Code-Review+1 (2 comments) Thanks, Amos! Minor comments left. I'll also let Henry and Marcel take a look at the catalog changes. http://gerrit.cloudera.org:8080/#/c/3942/16/fe/src/main/java/com/cloudera/impala/analysis/DropStatsStmt.java File fe/src/main/java/com/cloudera/impala/analysis/DropStatsStmt.java: Line 35: PartitionSet partitionSet_ = null; private final Line 90: TableRef tableRef = move this up and replace the analyzer.getTargetDbName() and analyzer.getTable() calls -- To view, visit http://gerrit.cloudera.org:8080/3942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird <amosb...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Amos Bird <amosb...@gmail.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-HasComments: Yes
