Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4117: Factor simple scheduler test code into own files ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4486/1/be/src/scheduling/simple-scheduler-test-util.h File be/src/scheduling/simple-scheduler-test-util.h: PS1, Line 28: impala Might be worth putting these classes in a sub-namespace since the names are super general sounding. That said, it shouldn't matter since I think this will only be pulled in by a one (maybe a few) tests? What do you think? -- To view, visit http://gerrit.cloudera.org:8080/4486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
