Lars Volker has posted comments on this change. Change subject: IMPALA-4117: Factor simple scheduler test code into own files ......................................................................
Patch Set 1: (2 comments) Thanks for the review, please see PS2. http://gerrit.cloudera.org:8080/#/c/4486/1/be/src/scheduling/simple-scheduler-test-util.h File be/src/scheduling/simple-scheduler-test-util.h: PS1, Line 28: impala > Might be worth putting these classes in a sub-namespace since the names are I gave it a try and I think it looks cleaner. Even if these are only included by a few tests, whatever those tests include can also lead to name collisions. PS1, Line 33: // Typedefs to make the rest of the code more readable. : typedef std::string Hostname; : typedef std::string IpAddr; Removed those as they are now duplicated in network-util.h -- To view, visit http://gerrit.cloudera.org:8080/4486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
