Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ......................................................................
Patch Set 6: I took a look at NLJ-builder. It seems to do much the same thing as this patch (AcquireState()), except if needs_to_return() is set it does a deep copy. Is there more to fixing this than adding the deep copy branch? (It seems that needs_to_return() acts as a 'sync' marker, so all earlier batches need to be copied out as well; that adds a little complication but not the end of the world). It's a bit unfortunate that we have this API because it explicitly disallows buffering without copying, but I see that it's there for a reason. -- To view, visit http://gerrit.cloudera.org:8080/4402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb0064ec2f085fa3a5598ea80894fb489a01e4df Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: No
