Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull-sink.cc File be/src/exec/push-pull-sink.cc: Line 31: constexpr int32_t QUEUE_DEPTH = 16; > Also we do want to deprecate need_to_return() but it's somewhat involved. I think it's a good idea to look into moving the exprs into the sink (at the same measuring the perf impact of the queue as Marcel suggests). For my information, tho, would it be correct simply to deep copy a batch and any unfinished-with previous batches if needs_to_return is set? -- To view, visit http://gerrit.cloudera.org:8080/4402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb0064ec2f085fa3a5598ea80894fb489a01e4df Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
