Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File be/src/rpc/rpc-trace.cc: PS2, Line 181: SIXTY_MINUTES_IN_MS If I understand correctly, this means the longest RPC call could be 60min. Isn't it too long? most of RPC should be in ms range or even shorter, 1 min is already abnormal, right? http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/util/histogram-metric.h File be/src/util/histogram-metric.h: PS2, Line 37: highest_trackable_value, num_significant_digits would it be worth to store those in HistogramMetric? -- To view, visit http://gerrit.cloudera.org:8080/4516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ba6d4270dd5676eeeff35ad8d9dc5dcddd95e34 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-HasComments: Yes
