Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc File be/src/rpc/rpc-trace.cc: PS3, Line 179: constexpr int32_t SIXTY_MINUTES_IN_MS = 60 * 1000 * 60; > I checked - any value > 60 minutes will be clipped to 60 minutes. That seem wfm, thanks for checking. -- To view, visit http://gerrit.cloudera.org:8080/4516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ba6d4270dd5676eeeff35ad8d9dc5dcddd95e34 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
