Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-4101: qgen: Hive join predicates should only contains 
equality functions
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4419/7/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

Line 1442:         signature = 
self.profile.choose_relational_func_signature(relational_signatures)
> Yeah, only_use_equality_join_predicates() is never called inside _create_bo
Agreed.


http://gerrit.cloudera.org:8080/#/c/4419/9/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

PS9, Line 1214:   
this should be 4 spaces, not 2.


-- 
To view, visit http://gerrit.cloudera.org:8080/4419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stak...@cloudera.com
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Reviewer: stak...@cloudera.com
Gerrit-HasComments: Yes

Reply via email to