Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/4419/7/tests/comparison/query_generator.py File tests/comparison/query_generator.py: Line 1214: if self.profile.only_use_equality_join_predicates(): This if statement should be above line 1211 and line 1211 should go into the else clause. PS7, Line 1216: self there should a 4 space indentation here PS7, Line 1356: signatures I think it would be clearer if this was renamed to allowed_signatures Line 1442: signature = self.profile.choose_relational_func_signature(relational_signatures) I like this. This means that we are not calling the only_use_equality_join_predicates() function at all in _create_boolean_func_tree? -- To view, visit http://gerrit.cloudera.org:8080/4419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: stak...@cloudera.com Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: stak...@cloudera.com Gerrit-HasComments: Yes
