Tim Armstrong has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4557/3/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: Line 2499: select count(shiftleft(int_col, 1)) from functional_parquet.alltypes > It fails with a warning. I think there's another bug in that ScalarFnCall::Prepare() doesn't fallback to interpretation if codegen fails. -- To view, visit http://gerrit.cloudera.org:8080/4557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a1291bfd202b500405a884e4a62f0ca2447244a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
