Michael Ho has posted comments on this change.

Change subject: IMPALA-4196: Cross compile bit-byte-functions
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4557/3/testdata/workloads/functional-query/queries/QueryTest/exprs.test
File testdata/workloads/functional-query/queries/QueryTest/exprs.test:

Line 2499: select count(shiftleft(int_col, 1)) from functional_parquet.alltypes
> No, it fails with a warning. Basically I tend to agree with Tim that the ex
I think that's a valid point that failure to codegen shouldn't be treated as a 
fatal error. In general, I think we should rethink on whether codegen should 
happen in ScalarFnCall()::Prepare(). If possible, we should just push the 
codegen to happen at the point when GetCodegenedComputeFn() is called the first 
time like other Expr. It may be slightly more tricky if the external UDF is 
entirely written in LLVM IR in which case there is no way to fall back to 
interpretation.

Anyhow, I don't think we need to address all of these in this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/4557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1291bfd202b500405a884e4a62f0ca2447244a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to