Taras Bobrovytsky has posted comments on this change.

Change subject: Don't assume that AUX exists just because a shell variable is 
set
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4563/2/tests/run-custom-cluster-tests.sh
File tests/run-custom-cluster-tests.sh:

PS2, Line 40: then
            :     impala-py.test custom_cluster/ authorization/ 
"${AUX_CUSTOM_DIR}" \
            :                    
--junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml" \
            :                    
--resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.log" "$@"
            : else
            :     impala-py.test custom_cluster/ authorization/ \
            :                    
--junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml" \
            :                    
--resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.log" "$@"
            : fi
I don't like the code repetition, and it's not clear right away what the 
difference is between the cases. How about something like:

ARGS=("custom_cluster/ authorization/ ");
if [ -d "${AUX_CUSTOM_DIR}" ] then
  ARGS+=(${AUX_CUSTOM_DIR} )
fi
ARGS+=("--junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml ")
ARGS+=("--resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.log ")
ARGS+=("$@")
impala-py.test "${ARGS[@]}"


-- 
To view, visit http://gerrit.cloudera.org:8080/4563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieffb6d52c5f95d3257de8c47a039ccb0d45f0867
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to