Jim Apple has posted comments on this change. Change subject: Don't assume that AUX exists just because a shell variable is set ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4563/2/tests/run-custom-cluster-tests.sh File tests/run-custom-cluster-tests.sh: PS2, Line 40: then : impala-py.test custom_cluster/ authorization/ "${AUX_CUSTOM_DIR}" \ : --junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml" \ : --resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.log" "$@" : else : impala-py.test custom_cluster/ authorization/ \ : --junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml" \ : --resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.log" "$@" : fi > I don't like the code repetition, and it's not clear right away what the di Done -- To view, visit http://gerrit.cloudera.org:8080/4563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieffb6d52c5f95d3257de8c47a039ccb0d45f0867 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
