Tim Armstrong has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4582/2/llvm-ir/test-loop.bc File llvm-ir/test-loop.bc: Did you run tests? This file is required by llvm-codegen-test. IMO it doesn't make sense to remove binary test data. Other apache projects check in this kind of thing, e.g. https://github.com/apache/avro/tree/master/share/test/data -- To view, visit http://gerrit.cloudera.org:8080/4582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
