Jim Apple has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4582/1//COMMIT_MSG Commit Message: PS1, Line 12: Please > It's kind of strange that this point starts with the word "Please" It was a quote; I've now quoted it. http://gerrit.cloudera.org:8080/#/c/4582/1/LICENSE.txt File LICENSE.txt: PS1, Line 269: > Remove these trailing white spaces. Done http://gerrit.cloudera.org:8080/#/c/4582/1/README.md File README.md: PS1, Line 30: right now. > at the moment Done http://gerrit.cloudera.org:8080/#/c/4582/2/llvm-ir/test-loop.bc File llvm-ir/test-loop.bc: > Did you run tests? This file is required by llvm-codegen-test. I did run tests. This patch causes this file to be listed as an explicit requirement for llvm-codegen-test; see the CMake file. The voter on the general@ mailing list said that binaries are OK, but not if they are compiled source code. -- To view, visit http://gerrit.cloudera.org:8080/4582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
