Youwei Wang has posted comments on this change. Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/4474/3//COMMIT_MSG Commit Message: Line 9: Purpose: Removes all instances of one or more characters from the > We should definitely not invent a new function name and stick to trim(). Th Done Line 32: NULL. Blank argument causes parsing error. > The 'where' and 'trim_char_set' clauses are optional, so the following are Done http://gerrit.cloudera.org:8080/#/c/4474/3/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: Line 2418: {: RESULT = c; :} > Not clear what this rule adds. The copy+paste nature of it means an increas Done Line 2449: > My understanding is that several of the trim() clauses are optional, e.g., Done -- To view, visit http://gerrit.cloudera.org:8080/4474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
