Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend ......................................................................
Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/4054/17/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS17, Line 483: // initialize progress updater : const string& str = Substitute("Query $0", PrintId(query_id_)); : progress_.Init(str, schedule_.num_scan_ranges()); > why was this wrong before? If there are no remote fragments I'd imagine Get the problem is if there are remote fragments, but starting the coordinator instance fails in prepare. i added a comment to the .h file which says that no elements of fragment_instance_states_ will ever be nullptr. if you resize here you end up with that scenario (exposed through a test). -- To view, visit http://gerrit.cloudera.org:8080/4054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I240445199e22f009f4e72fdb8754eb8d77e3d680 Gerrit-PatchSet: 18 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-HasComments: Yes
