Alex Behm has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4448/6/be/src/exec/analytic-eval-node.cc File be/src/exec/analytic-eval-node.cc: Line 758: if (row_batch->num_blocks() > 0) row_batch->MarkFlushResources(); Can we move this logic into BufferedTupleStream::Close()? http://gerrit.cloudera.org:8080/#/c/4448/6/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 356: bool flush_resources_; I don't see flush_resources_ being read/returned. Could we replace FlushResources() with MarkAtCapacity()? -- To view, visit http://gerrit.cloudera.org:8080/4448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6471422f86ce71e4c6ab277a276000051bc2e8ff Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
