Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4448/6/be/src/exec/analytic-eval-node.cc File be/src/exec/analytic-eval-node.cc: Line 758: if (row_batch->num_blocks() > 0) row_batch->MarkFlushResources(); > Thanks for explaining, that makes sense to me. Added the flag to RowBatch::AddBlock(), which is forwarded from BufferedTupleStream::CLose() -- To view, visit http://gerrit.cloudera.org:8080/4448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6471422f86ce71e4c6ab277a276000051bc2e8ff Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
