Tim Armstrong has posted comments on this change. Change subject: IMPALA-3943: Do not throw scan errors for empty Parquet files. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4693/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 413: if (row_group.num_rows == 0 || file_metadata_.num_rows == 0) continue; How do we even get here if the checks on line 411 and line 413 pass? Line 411 should cover the case where there are no row groups, and the check on line 413 should cover the case when the row group is empty. Is the row group metadata just corrupt in these files? -- To view, visit http://gerrit.cloudera.org:8080/4693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ac3df6ff24bc5c384ef22e0f804a5132adb62e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
