Alex Behm has posted comments on this change. Change subject: IMPALA-3943: Do not throw scan errors for empty Parquet files. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4693/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 413: if (row_group.num_rows == 0 || file_metadata_.num_rows == 0) continue; > So I'm right in thinking that the input file is corrupt rather than a valid What should we do with abort_on_error? I can add a comment in a follow-on patch, but the I don't think this ode here is particularly confusing, it seems to make sense. -- To view, visit http://gerrit.cloudera.org:8080/4693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ac3df6ff24bc5c384ef22e0f804a5132adb62e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
