Tim Armstrong has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() ......................................................................
Patch Set 3: (8 comments) Looking good, just some small things then I'll +1. http://gerrit.cloudera.org:8080/#/c/4651/1/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: Line 174: void AggregationNode::Codegen(RuntimeState* state) { > I thought about something similar but this has the side effect of putting " Ah, I didn't think about that. This works ok for now then. http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: Line 169: runtime_profile()->AddCodegenMsg(false, "disabled by query option DISABLE_CODEGEN"); Thanks, I think this will be clearer. It's still a little weird that we don't print anything when expr codegen is disabled (since that can make a bit perf difference), but I guess that will be fixed naturally by a follow-up patch. http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/hash-join-node.cc File be/src/exec/hash-join-node.cc: Line 172: Function* codegen_process_probe_batch_fn = CodegenProcessProbeBatch(codegen, hash_fn); Long line. http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 622: return Status("Disabled by query option."); Dead code I think. http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: Line 153: Status HdfsScanNodeBase::Prepare(RuntimeState* state) { It doesn't look like we add the codegen disabled message hre. http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 700: return Status("Disabled by query option."); Dead code? http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: Line 562: #define ARG_DECL_LIST(n) \ Thanks for doing this. Can you add a comment just giving an example of what the macros expand to? http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/service/fe-support.cc File be/src/service/fe-support.cc: Line 104: state.CreateCodegen(), env, JniUtil::internal_exc_class(), result_bytes); Tab? -- To view, visit http://gerrit.cloudera.org:8080/4651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I207566bc9f4c6a159271ecdbc4bbdba3d78c6651 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
