Dan Hecht has posted comments on this change.

Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()
......................................................................


Patch Set 4:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4651/4/be/src/exec/exec-node.h
File be/src/exec/exec-node.h:

PS4, Line 72:  If overridden in subclass, must also
            :   /// call superclass's Codegen().
does it matter whether this happens first or last?


http://gerrit.cloudera.org:8080/#/c/4651/4/be/src/exec/hash-join-node.cc
File be/src/exec/hash-join-node.cc:

Line 148:   }
why not do this in ExecNode::Prepare() to avoid having to do the same thing in 
every derived class?


http://gerrit.cloudera.org:8080/#/c/4651/4/be/src/exec/partitioned-hash-join-builder.h
File be/src/exec/partitioned-hash-join-builder.h:

PS4, Line 88: whether the codegen was
            :   /// enabled 
we only call this if codegen is enabled, right?  So I'm not sure what this part 
means (maybe just delete it).


http://gerrit.cloudera.org:8080/#/c/4651/4/be/src/exprs/scalar-fn-call.cc
File be/src/exprs/scalar-fn-call.cc:

Line 409:   // TODO: fix this
not for this change, but i think this timestamp stuff may have been fixed by 
moving things out of the IR.


http://gerrit.cloudera.org:8080/#/c/4651/4/be/src/runtime/runtime-state.h
File be/src/runtime/runtime-state.h:

PS4, Line 161: 'codegen_'.
public method comments shouldn't really talk about private members. how about 
"... for this fragment instance" or something like that.


http://gerrit.cloudera.org:8080/#/c/4651/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

Line 532
why is it okay to always enable codegen now, whereas before we were so careful 
to only enable it based on this heuristic?


http://gerrit.cloudera.org:8080/#/c/4651/4/tests/query_test/test_udfs.py
File tests/query_test/test_udfs.py:

Line 80:     vector.get_value('exec_option')['disable_codegen'] = 1
this doesn't invalidate any of the preexisting test cases?


-- 
To view, visit http://gerrit.cloudera.org:8080/4651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I207566bc9f4c6a159271ecdbc4bbdba3d78c6651
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to