Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ......................................................................
Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/4402/12/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 1522: // should explicitly pass Status::OK()). See IMPALA-4279. > good explanation. could you put that somewhere, i agree that there's a bit Done http://gerrit.cloudera.org:8080/#/c/4402/12/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: Line 705: // higher in the call-stack. > where is this being done now? Changed the DCHECK to return an error Status, since we can't control the clients. -- To view, visit http://gerrit.cloudera.org:8080/4402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb0064ec2f085fa3a5598ea80894fb489a01e4df Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
