Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking ......................................................................
Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/4494/10/be/src/util/bit-packing-test.cc File be/src/util/bit-packing-test.cc: PS10, Line 39: it > them Done PS10, Line 39: Both > Both buffers Done Line 60: uint8_t* packed = storage.data() + aligned; > If aligned is true, then packed is not aligned Done http://gerrit.cloudera.org:8080/#/c/4494/10/be/src/util/bit-packing.inline.h File be/src/util/bit-packing.inline.h: Line 41: #define UNPACK_VALUES_CASE(ignore1, i, ignore2) \ > Here is a way to do this without any macros, but it's a bit heavyweight fro IMO the macro is easier to understand because the macro bears some relation to the code being stamped out. Also you have a better chance of debugging it by looking at the preprocessed output. I think the macro makes sense in this case since we're really just trying to stamp out repetitive code instead of build an abstraction. -- To view, visit http://gerrit.cloudera.org:8080/4494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12db69409483d208cd4c0f41c27a78aeb6cd3622 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
