Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking ......................................................................
Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4494/11/be/src/util/bit-packing.inline.h File be/src/util/bit-packing.inline.h: Line 140: const int bytes_to_read = BitUtil::RoundUpNumBytes(32 * BIT_WIDTH); constexpr BYTES_TO_READ, if you mark BitUtil::RoundUpNumBytes constexpr, or if you write BIT_WIDTH*32/CHAR_BIT instead -- To view, visit http://gerrit.cloudera.org:8080/4494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12db69409483d208cd4c0f41c27a78aeb6cd3622 Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
