Charlie Helin has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations ......................................................................
Patch Set 1: -Code-Review > Did a grep for HADOOP_HOME, and this might need to be changed too: > https://github.com/apache/incubator-impala/blob/75a857c0ceb6a58691ff45f0df8d88586edc8acd/buildall.sh#L357 Yes here it seems like ${HADOOP_HOME}\lib should categorically be substituted by ${HADOOP_LIB_DIR}. But regarding this line it also looks like we need to parameterize HADOOP LZO? -- To view, visit http://gerrit.cloudera.org:8080/4720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7da10e38f9c4309f2d193dc25f14a6ea308c9639 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Charlie Helin <che...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No
