Charlie Helin has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4720/2/bin/impala-config.sh File bin/impala-config.sh: Line 145: export CDH_MAJOR_VERSION=5 Bump? Line 146: export HADOOP_LZO="${HADOOP_LZO-$IMPALA_HOME/../hadoop-lzo}" How is this assigned? Line 289: export KUDU_JAVA_VERSION=1.0.0-SNAPSHOT This shouldn't be configurable too? Line 325: export HADOOP_HOME="$CDH_COMPONENTS_HOME/hadoop-${IMPALA_HADOOP_VERSION}/" It's a bit confusing with 2 concurrent and related reviews. But it seems to me that HADOOP_HOME also should be configurable, otherwise we would assume that the components are laid out in particular fashion. Line 345: export SENTRY_HOME="$CDH_COMPONENTS_HOME/sentry-${IMPALA_SENTRY_VERSION}" same as 325 Line 348: export HIVE_HOME="$CDH_COMPONENTS_HOME/hive-${IMPALA_HIVE_VERSION}/" same as 325 -- To view, visit http://gerrit.cloudera.org:8080/4720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7da10e38f9c4309f2d193dc25f14a6ea308c9639 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Charlie Helin <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
