Henry Robinson has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load ......................................................................
Patch Set 5: (2 comments) I'm a bit worried about the compatibility of this change: if someone has set --local_library_dir to some local staging dir, will they be surprised when that dir is emptied after this patch? I wonder if we need to hide this behaviour behind a flag. http://gerrit.cloudera.org:8080/#/c/4617/5/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: PS5, Line 39: LOCAL_LIBRARY_DIR = "/tmp/" + get_random_id(5) use mkdtemp? PS5, Line 237: assert len(glob.glob(self.LOCAL_LIBRARY_DIR + "/*.jar")) == 0 comment what this is checking -- To view, visit http://gerrit.cloudera.org:8080/4617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f9dedb5b342415380c83e61a72eb497371a8199 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
