Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load ......................................................................
Patch Set 5: bq: I'm a bit worried about the compatibility of this change: if someone has set --local_library_dir to some local staging dir, will they be surprised when that dir is emptied after this patch? I wonder if we need to hide this behaviour behind a flag. Not sure I follow you. We only delete the temporary jar that our code adds to that directory (CatalogServiceCatalog.java). I'm guessing that your observation is based on the test case I added (please correct me if I'm wrong). That behavior is specific to the test runs where that directory is a random one created on the fly and won't have any other jars added to it and the assert holds. In practice that directory can have any other stuff too, that we don't touch. -- To view, visit http://gerrit.cloudera.org:8080/4617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f9dedb5b342415380c83e61a72eb497371a8199 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: No
