Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: Line 132: KUDU_RETURN_IF_ERROR(s, "Unable to set flush mode"); // Return error status for RELEASE > fwiw, our reasoning for making even simple setter calls return Status is fo Ok, thanks -- To view, visit http://gerrit.cloudera.org:8080/4728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5542b9a061b01c543a139e8722560b1365f06595 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes