Dan Hecht has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements ......................................................................
Patch Set 7: (2 comments) Code looks fine, but want to close on the question at line 330 before +2ing. http://gerrit.cloudera.org:8080/#/c/4728/6/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: PS6, Line 330: > I think so: If that happens we'll fail the query. If the query fails, the ' Does that reasoning hold up even if all errors are IGNORE type errors and we overflow the client error buffer? http://gerrit.cloudera.org:8080/#/c/4728/7/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: PS7, Line 145: Kudu is this talking about the "Kudu client" or "Kudu server"? -- To view, visit http://gerrit.cloudera.org:8080/4728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5542b9a061b01c543a139e8722560b1365f06595 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
