David Knupp has posted comments on this change. Change subject: Enabling end-to-end tests on a remote cluster ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4769/1/bin/remote_data_load.py File bin/remote_data_load.py: PS1, Line 88: RemoteDataLoad > I'd separate out the common functionality needed for dealing with remote cl IMPALA-4367 has been filed. PS1, Line 132: v10 > Hardcoding v10. Is this necessary? I think URL may be missing with later IMPALA-4367 has been filed. PS1, Line 155: get_service_client_configurations > A lot of this seems like it could be in comparisons/cluster.py, or at least IMPALA-4367 has been filed. PS1, Line 212: find_snapshot_file > It would be good to start converting the snapshot file management into pyth IMPALA-4367 has been filed. -- To view, visit http://gerrit.cloudera.org:8080/4769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f443a1728a1d28168090c6f54e82dec2cb073e9 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Harrison Sheinblatt <[email protected]> Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
