Harrison Sheinblatt has posted comments on this change.

Change subject: Enabling end-to-end tests on a remote cluster
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4769/1/bin/remote_data_load.py
File bin/remote_data_load.py:

PS1, Line 365: main
> I'm having a bit of trouble parsing this sentence. Can you clarify?
With the parser options directly in main() it would be difficult to invoke the 
main() logic from another python script without shelling out to execute the 
script as a sub process. If instead, you define the parse options in a separate 
method, and create a method that does all the logic in main() but takes a 
parameter of the args, then another python program could set an arg dictionary 
and invoke the main logic directly without need to shell out.


-- 
To view, visit http://gerrit.cloudera.org:8080/4769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f443a1728a1d28168090c6f54e82dec2cb073e9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Harrison Sheinblatt <[email protected]>
Gerrit-Reviewer: Martin Grund <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-HasComments: Yes

Reply via email to