Tim Armstrong has posted comments on this change. Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). ......................................................................
Patch Set 1: (7 comments) Mostly looks good - would be good to know whether any queries regressed with the change. http://gerrit.cloudera.org:8080/#/c/4833/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: PS1, Line 1415: ExternalLinkage Why not private linkage? http://gerrit.cloudera.org:8080/#/c/4833/1/be/src/exec/filter-context.cc File be/src/exec/filter-context.cc: Line 90: // @expr_type_arg = constant %"struct.impala::ColumnType" { i32 4, i32 -1, i32 -1, What query produced this? Line 155: codegen->GetFunction(IRFunction::RUNTIME_FILTER_EVAL, true); Do we need to clone this function? It doesn't look like we modify it. Line 205: return Status("Codegen'ed FilterContext::Eval() fails verification, " Weird wrapping. http://gerrit.cloudera.org:8080/#/c/4833/1/be/src/runtime/runtime-filter.h File be/src/runtime/runtime-filter.h: Line 64: bool Eval(void* val, const ColumnType& col_type) const noexcept; Document 'val' - not self-explanatory Line 86: static const char* LLVM_CLASS_NAME; Missed this one http://gerrit.cloudera.org:8080/#/c/4833/1/tests/query_test/test_tpch_queries.py File tests/query_test/test_tpch_queries.py: Line 39: v.get_value('table_format').file_format in ['text', 'parquet', 'kudu']) Does this provide meaningful coverage? It doesn't seem like it's worth running on both text and parquet in core. -- To view, visit http://gerrit.cloudera.org:8080/4833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27114869840e268d17e91d6e587ef811628e3837 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
