Michael Ho has posted comments on this change.

Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and 
fixes filter stats updates
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4833/3//COMMIT_MSG
Commit Message:

PS3, Line 7: IMPALA-3838, 
> Need to update commit message to mention IMPALA-4495.
Done


http://gerrit.cloudera.org:8080/#/c/4833/3/be/src/exec/filter-context.cc
File be/src/exec/filter-context.cc:

PS3, Line 137: LlvmCodeGen::FnPrototype prototype(codegen, "FilterContextEval",
> long line.
Done


http://gerrit.cloudera.org:8080/#/c/4833/3/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

PS3, Line 286: total_poss
> total_possible
Done


PS3, Line 700: noinline
> noinline
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27114869840e268d17e91d6e587ef811628e3837
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to