Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: DiskIoMgr improvements for new buffer pool ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4631/3/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: PS3, Line 165: external_buffer_tag_ != ExternalBufferTag::CACHED_BUFFER > !is_cached_buffer()? (either way is okay with me but sometimes you write th is_cached_buffer() is a method of BufferDescriptor - there isn't an equivalent method of ScanRange. PS3, Line 450: external_buffer_tag_ != ExternalBufferTag::CACHED_BUFFE > this could be stronger DCHECK_EQ(..., NO_BUFFER), right? (Also use the NE/ The NE/EQ macros don't work for strongly-typed "enum class" unions unfortunately. It works for the old-style enums since they decay to ints. I felt like this was the lesser evil. http://gerrit.cloudera.org:8080/#/c/4631/3/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: Line 641: && range->external_buffer_tag_ != ScanRange::ExternalBufferTag::CLIENT_BUFFER) { > or !is_client_buffer() (i'm fine either way, but just a bit shorter and wha is_client_buffer() is a method of BufferDescriptor so doesn't work here. I could add accessors to ScanRange, but I don't feel like they carry their wieght. PS3, Line 1066: range->external_buffer_tag_ == ScanRange::ExternalBufferTag::CLIENT_BUFF > same See above -- To view, visit http://gerrit.cloudera.org:8080/4631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I913fbb8ae6c242f1585992eb2a622509344dccec Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
