Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: DiskIoMgr improvements for new buffer pool ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4631/3/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: PS3, Line 450: external_buffer_tag_ != ExternalBufferTag::CACHED_BUFFE > The NE/EQ macros don't work for strongly-typed "enum class" unions unfortun okay. but still, wouldn't thie be clearer to check: DCHECK(external_buffer_tag_ == ExternalBufferTag::NO_BUFFER)? i.e. it's not okay to have a client buffer here either. -- To view, visit http://gerrit.cloudera.org:8080/4631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I913fbb8ae6c242f1585992eb2a622509344dccec Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
