Tim Armstrong has posted comments on this change. Change subject: IMPALA-4302,IMPALA-2379: constant expr arg fixes ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4838/3/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: Line 396: /// Initialise a constant global string and returns a pointer to it. Need to doc that it's an i8* http://gerrit.cloudera.org:8080/#/c/4838/3/be/src/exprs/anyval-util.h File be/src/exprs/anyval-util.h: Line 21: #include "gutil/strings/substitute.h" Move to .cc http://gerrit.cloudera.org:8080/#/c/4838/3/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: Line 337: // Get IR i8* pointer to a varargs buffer. We allocate the buffer with Alloca so that needs updating, not an i8 -- To view, visit http://gerrit.cloudera.org:8080/4838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45c3ed8c9d7a61e94a9b9d6c316e8a53d9ff6c24 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
