Dan Hecht has posted comments on this change. Change subject: IMPALA-4302,IMPALA-2379: constant expr arg fixes ......................................................................
Patch Set 4: (11 comments) Looks good. I think just comments about comments. http://gerrit.cloudera.org:8080/#/c/4838/4//COMMIT_MSG Commit Message: Line 18: arguments for ScalarFnCall expressions on both the codegen'd and missing words PS4, Line 36: temporary automatic? at least I would have understood this a little quicker with that terminology. http://gerrit.cloudera.org:8080/#/c/4838/4/be/src/exprs/agg-fn-evaluator.cc File be/src/exprs/agg-fn-evaluator.cc: PS4, Line 158: ", is it worth differentiating these messages to make debugging easier? http://gerrit.cloudera.org:8080/#/c/4838/4/be/src/exprs/anyval-util.h File be/src/exprs/anyval-util.h: PS4, Line 297: The returned AnyVal is not initialized. this sentence is repeated http://gerrit.cloudera.org:8080/#/c/4838/4/be/src/exprs/expr-context.h File be/src/exprs/expr-context.h: PS4, Line 66: fragment do you mean fragment instance? http://gerrit.cloudera.org:8080/#/c/4838/4/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: PS4, Line 188: fragment fragment or fragment instance? PS4, Line 189: cases not sure what this sentence is saying. what cases? Line 205: // children. do we document the calling convention somewhere? I think a brief explanation would help casual readers understand why the interpreted path and codegen path set things up the way they do. PS4, Line 340: optimise out the buffer is this also enabling constant propagation for constant args, or was that already happening? PS4, Line 370: Either no varargs or arguments before varargs begin this comment seems unnecessary with the new conditional http://gerrit.cloudera.org:8080/#/c/4838/4/be/src/runtime/free-pool.h File be/src/runtime/free-pool.h: Line 73: size = std::max<int64_t>(8, size); seems fine, but why is it required? -- To view, visit http://gerrit.cloudera.org:8080/4838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45c3ed8c9d7a61e94a9b9d6c316e8a53d9ff6c24 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
