Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Throw if Kudu table created with var/char ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4857/1//COMMIT_MSG Commit Message: PS1, Line 10: analysis Actually, this is not correct. We throw an ImpalaRuntimeException in the catalog. However, I am wondering if it makes more sense to perform the type checks during the analysis. http://gerrit.cloudera.org:8080/#/c/4857/1/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: PS1, Line 231: String storageHandler = properties.get(KuduTable.KEY_STORAGE_HANDLER); : Preconditions.checkState(!Strings.isNullOrEmpty(storageHandler)); : if (!storageHandler.equals(KuduTable.KUDU_STORAGE_HANDLER)) Maybe we can replace all this with if (!KuduTable.isKuduTable(msTbl)) which does the exact same check. -- To view, visit http://gerrit.cloudera.org:8080/4857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I475273cbbf4110db8d0f78ddf9a56abfc6221e3e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
