Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking ......................................................................
Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4857/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: PS2, Line 1362: VARCHAR(32) Maybe add one for decimal as well? PS2, Line 1363: AnalysisError("create table t primary key (id) distribute by hash into 3 buckets" + : " stored as kudu as select id, s from functional.complextypes_fileformat", : "Expr 's' in select list returns a complex type 'STRUCT<f1:STRING,f2:INT>'.\n" + : "Only scalar types are allowed in the select list."); : AnalysisError("create table t primary key (id) distribute by hash into 3 buckets" + : " stored as kudu as select id, m from functional.complextypes_fileformat", : "Expr 'm' in select list returns a complex type 'MAP<STRING,BIGINT>'.\n" + : "Only scalar types are allowed in the select list."); : AnalysisError("create table t primary key (id) distribute by hash into 3 buckets" + : " stored as kudu as select id, a from functional.complextypes_fileformat", : "Expr 'a' in select list returns a complex type 'ARRAY<INT>'.\n" + : "Only scalar types are allowed in the select list."); I am not sure this exercises any Kudu-related code path. This error probably comes from the analysis of the SelectStmt before the CreateTableStmt object of the CreateTableAsSelect is analyzed. Maybe remove? -- To view, visit http://gerrit.cloudera.org:8080/4857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I475273cbbf4110db8d0f78ddf9a56abfc6221e3e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
